Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue w/ outputDir in case of using code-signing #545

Merged
merged 1 commit into from
Dec 13, 2017

Conversation

sergey-akhalkov
Copy link
Contributor

relates to #544

@sergey-akhalkov
Copy link
Contributor Author

@max-mironov, @ruslan-bikkinin JFYI - going to fix the same in the https://github.com/Microsoft/appcenter-cli after approval from @PaperMonster that the issue is fixed w/ this PR

@shashankwadi
Copy link

Is this Fixed? Not working for mw still RN version is .51

@SudoPlz
Copy link

SudoPlz commented Nov 18, 2019

Hey @sergey-akhalkov @max-mironov , thanks for all the great work.
Does this PR mean that the path will always be <ourBuildOutputPath>/CodePush/

Looks like the CodePush/ dir is always created and appended to our build output path.

Thanks

@alexandergoncharov-zz alexandergoncharov-zz deleted the fix-outputdir-code-signing branch December 16, 2019 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants