-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update RustCli Parsing to process pkgId, and introduce manual override #1106
Conversation
… fallback with DisableRustCliScan
👋 Hi! It looks like you modified some files in the
If none of the above scenarios apply, feel free to ignore this comment 🙂 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1106 +/- ##
=======================================
+ Coverage 75.7% 75.9% +0.2%
=======================================
Files 239 247 +8
Lines 10822 11089 +267
Branches 1086 1137 +51
=======================================
+ Hits 8193 8419 +226
- Misses 2317 2347 +30
- Partials 312 323 +11 ☔ View full report in Codecov by Sentry. |
src/Microsoft.ComponentDetection.Detectors/rust/RustCliDetector.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.ComponentDetection.Detectors/rust/RustCliDetector.cs
Outdated
Show resolved
Hide resolved
@FernandoRojo to verify, the new locations in snapshot verification are expected correct? |
Allows users to manually override rustCLI detector by setting an environment variable DisableRustCliScan=True
Updates cargo metadata output processing to adhere to changes introduced that make the output follow the PkgId Spec: https://doc.rust-lang.org/cargo/reference/pkgid-spec.html
Changes to the metadata output were introduced in 1.77: rust-lang/cargo#12914