ci(build): build on windows and linux #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #760 +/- ##
==========================================
+ Coverage 72.83% 74.32% +1.48%
==========================================
Files 227 227
Lines 9756 9756
==========================================
+ Hits 7106 7251 +145
+ Misses 2650 2505 -145 |
melotic
changed the title
|
Cannot add MacOS support, as it doesn't include docker, which is needed for some tests: actions/runner-images#17 (comment) Could add a skip tests on MacOS attribute, but I think this is good enough. |
melotic
force-pushed
the
justinperez/cross-platform-build
branch
from
325cc7a to
fb6a527
Compare
cobya
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have some tests that are not run on windows and vice verse. We should be running those tests in CI.