Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Correct data type 'number' constant to 'n' #89

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Correct data type 'number' constant to 'n' #89

wants to merge 1 commit into from

Commits on Feb 8, 2024

  1. fix: Correct data type 'number' constant to 'n' 

    The official xlsx spec defines that the t property of a cell should have
 t='n' if the cell type is number.
 This also makes the exported Excel sheet work with LibreOffice
 correctly, since that expects 'n' as the type of number cell.
 Before, sheets exported with connected-workbooks and opened in
 LibreOffice calc would not display numbers in number cells at all.
 For Excel sheets, this does not change anything, since Excel
 understands 'n'
 as the type as well. Actually, '1' is a derivative from the spec, and
 it
  seems to be just per chance that Excel understands it.
  Therefore, I changed dataTypeKind.number from '1' to 'n'.
    @janmagnusdev
    janmagnusdev committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    0a10de5 View commit details
    Browse the repository at this point in the history