Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project stopped building with MSBuild 16.10.0 #883

Merged
merged 5 commits into from
May 28, 2021

Conversation

maxgolov
Copy link
Contributor

@maxgolov maxgolov commented May 28, 2021

Unfortunately we got hit by MSBuild bug in Visual Studio 2019 16.10.0 , which will only be solved in 16.10.1

This one: dotnet/msbuild#6373

Workaround was proposed by Scott Mitten. I tested it locally with that exact MSBuild that is affected.

The workaround is that every target now must contain :Rebuild ( what a waste of space! ), and then projects get built successfully. Since we got a few folks affected immediately, and since the fix is expected in a a few weeks, I'd suggest we fix it now to avoid any questions and confusion. This will also resolve some immediate build pipeline issues. This will also help us in case of someone already downloaded and installed 16.10.0, but forgets to patch it later... we'd still work fine with that version.

A follow-up PR would be necessary in the local mstelemetry portfile.cmake to point to latest commit id once this PR is merged. I am, however, adjusting the TARGET sqlite:Rebuild,win32-lib:Rebuild in the portfile itself. That's the main change that keeps things buildable even with MSBuild 16.10.0

NOTE: I have not tested this with old MSBuild, only tested with MSBuild that comes with vs2019 16.10.0, and I hope that the GitHub action runner will verify the build scripts for me using an older version of MSBuild.

One unrelated change: zlib was anchoring to v141, so I patched it to reuse the settings from before.targets instead.

@maxgolov maxgolov merged commit a0aae11 into master May 28, 2021
@maxgolov maxgolov deleted the maxgolov/vs2019_16.10_msbuild_workaround branch May 28, 2021 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants