-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
outside_tests hit servers with behavior that depends on country of origin #27
Comments
I found the following patch in Ubuntu's
Could it be the same problem on Arch Linux? |
Hmm, this might be the issue. It looks like https://en.wikipedia.org/wiki/HTTP_302 is Redirect, so are the tests possibly being run under some sort of proxy? What is your testing environment? Archlinux 64-bit on a desktop computer with internet? |
Yes, Arch Linux 64-bit desktop with Internet connection. No, there is no proxy involved. At least, I'm not aware of the one as this is my personal box and I didn't install any proxy here. |
Odd. At the very least, I don't think the core library functionality should be diminished. After running the tests again and ensuring they fail on your current internet connection, could you paste the results of |
There you go:
|
Aha, this looks like a US-centrism on our part. Apparently cnn.com redirects users from other countries to the "http://edition.cnn.com/" drop location, which is causing the problem. This means that 1) you can consider these tests passing ☺ and 2) these tests should probably be changed to hit the international home pages (which at least in the cnn case does not redirect even in the US). Thanks for reporting this issue; if you'd like to prepare a PR changing the tests please do. |
On FreeBSD this fails too. |
I have the same issue on Mac OS X. Here's the list of failed tests:-
Using curl shows the redirections. That means the tests have not been updated so far. CNN:
Google:
But, what about the other failures? Any thoughts? |
- http://www.cnn.com redirects users from countries outside of the US to the "http://edition.cnn.com/" drop location - Use http://edition.cnn.com, which does not redirect - even in the US - Fix microsoft#27
Built from the latest revision (78f8554) in the
master
branch:Any ideas?
Kind regards,
Alexander
The text was updated successfully, but these errors were encountered: