Improve CI jobs split #1210
Merged
Improve CI jobs split #1210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is more or less a straight port with slightly improved control flow. All tests are still built and run serially.
This build was failing from the start.
If a debug assertion or error occurs, this dialog blocks execution of the CI.
Have to hack catch2.hpp a bit so that it outputs ANSI colour sequence.
kennykerr
reviewed
Oct 18, 2022
| @@ -44,94 +44,96 @@ namespace | |||
| } | |||
| } | |||
|
|
|||
| TEST_CASE("disconnected,handler") | |||
| TEST_CASE("disconnected,handler,1") | |||
kennykerr
reviewed
Oct 18, 2022
|
|
||
| { | ||
| auto async = Action(); | ||
| TEST_CASE("disconnected,handler,2") |
There was a problem hiding this comment.
Oh, you flattened these tests...
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kennykerr
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This basically rewrites the CI jobs based on the original
build_test_all.cmdbut split the steps into different jobs so any failures will be easier to pinpoint. This also allows the tests to be built and run in parallel, which can save about 5 minutes of full run time.One thing to note is that the nuget test build seems to be failing even on the initial GHA workflow. This failure was hidden before because
build_test_all.cmddid not detect the build error. Now that it is exposed, I have added a hack to purposely ignore the failure (instead only emit a warning) because I don't know how to fix it properly.