Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: sort .gitignore entries for readability #133

Closed
wants to merge 1 commit into from
Closed

style: sort .gitignore entries for readability #133

wants to merge 1 commit into from

Conversation

hamirmahal
Copy link
Contributor

hamirmahal
hamirmahal commented Oct 29, 2024
View reviewed changes
Copy link
Contributor Author

@hamirmahal hamirmahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should hopefully make Playwright more enjoyable to use for developers who add it to their projects.

@Skn0tt
Copy link
Member

Skn0tt commented Oct 30, 2024 •
edited
Loading

We're not taking style contributions in this project. Besides, the current ordering is fine. Not everything in life needs to be alphabeticised.

@Skn0tt Skn0tt closed this Oct 30, 2024
@Skn0tt Skn0tt mentioned this pull request Oct 30, 2024
Closed
@hamirmahal hamirmahal deleted the style/sort-gitignore-entries-for-readability branch October 30, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: playwright should add entries to .gitignore in sorted order
2 participants
@hamirmahal @Skn0tt