Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] disable --limit on show (again) #235

Merged
merged 1 commit into from
Apr 15, 2024
Merged

[bug] disable --limit on show (again) #235

merged 1 commit into from
Apr 15, 2024

Conversation

dataders
Copy link
Contributor

60d33ea of #201, mistakenly added the get_show_sql() macro, and shouldn't have. Accordingly I mistakenly thought with #230 that I editing it would have an effect (spoiler: it didn't).

This PR:

  • removes get_show_sql()
  • modifies synapse__get_limit_subquery_sql() directly

@dataders dataders changed the title incorrect inclusion on non-dispatched macro [bug] disable --limit on show (again) Apr 15, 2024
@prdpsvs prdpsvs merged commit 8f4a6a3 into master Apr 15, 2024
9 checks passed
dataders pushed a commit that referenced this pull request Apr 15, 2024
[bug] disable `--limit` on `show` (again)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants