Use importlib instead of imp in qt_loaders.py #1569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…portlib if necessary.
|
@microsoft-github-policy-service agree |
bruchim-cisco
approved these changes
May 6, 2024
|
@bruchim-cisco my bad, I didn't mean to rerequest a review, I must've misclicked on something. Please disregard. |
|
Hi, Just a gentle reminder. :) It seems this is not merged by some mistake? |
|
Merged new changes, all good on my end @larstokle @bruchim-cisco |
|
@stermart there's still conflicts, can you remerge? |
|
Should be good now(?) @rchiodo |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rchiodo
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1531.