-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow python 3.12 in attach code #1580
Conversation
Downloading windows artifacts from https://github.com/microsoft/debugpy/actions/runs/8993404815?pr=1580 and testing attach scenario locally. |
The attach DOES work now, we got past the "unknown python version" errors. But breakpoints are not getting hit like they were in when using python 3.11. @int19h - I know debugpy works with python 3.12, but is there anything special I need to do to the attach code for breakpoints to be hit when attaching? This scenario works for 3.11 but not 3.12. Thanks! |
The other place that needs to be updated is here. Without this DLL, it will not be able to set tracing on existing threads. debugpy/src/debugpy/_vendored/pydevd/pydevd_tracing.py Lines 252 to 256 in 09b5af0
|
But then the DLL itself needs to implement this function for Python 3.12: debugpy/src/debugpy/_vendored/pydevd/pydevd_attach_to_process/common/py_custom_pyeval_settrace.hpp Lines 6 to 8 in 09b5af0
debugpy/src/debugpy/_vendored/pydevd/pydevd_attach_to_process/common/py_custom_pyeval_settrace.hpp Lines 170 to 190 in 09b5af0
|
That is the trickiest part. This is the implementation for Python 3.11, and I believe much of this has changed for 3.12 (e.g. |
we can also add python 3.13? |
Creating this PR so the dll's get generated through github actions. Once they are available as artifacts, I will download them and test locally.