RangeError when trying to initialise display on my ESP32S3-BOX-LITE devkit

[sambenko]

Hello,

I've started working with Devicescript and trying to initialise display for different esp32s3 box devkits. I've created a custom board json file and loaded the pins, configured the spi and created new ST7789Driver instance. However, I can't input the actual display size of my device, the LCD screen has the resolution of 240x320 and I get this error:

deploy to NH67
DEV> stop program
  --> done, 10.8kb
DEV> Espressif ESP32-S3-BOX-LITE v2.15.12; file v2.15.15
DEV> start: ./ v0.0.1-3bba539-2023.10.19.15.09
DEV> Unhandled exception
DEV> Exception: RangeError
DEV>  message: invalid dimensions 240x320x4
DEV>  at main [as F0_pc93] (src/main.ts:16:1)
DEV> Unhandled exception
DEV> stop program

even when I switched the values 240 and 320, still getting the same error. This is my main.ts (the highest I can go with values is 260 and 220):

import { pins } from "@dsboard/esp32s3_box_lite";
import * as ds from "@devicescript/core";
import { ST7789Driver } from "@devicescript/drivers";
import { spi } from "@devicescript/spi";
import { Image } from "@devicescript/graphics";

spi.configure({
    mosi: pins.P6,
    sck: pins.P7,
    miso: pins.P13,
    hz: 40_000_000,
})

pins.P45.setMode(ds.GPIOMode.OutputHigh) // backlight set high

const display = new ST7789Driver(Image.alloc(260, 220, 4), { 
    dc: pins.P4,
    cs: pins.P5,
    reset: pins.P48,
    flip: true, 
    spi: spi,
    offX: 0,
    offY: 0,  
})

pins.P45.setMode(ds.GPIOMode.OutputLow) // backlight set low

await display.init();
await display.image.printCenter("Hello World!", display.image.height / 2);
await display.show();

Is my device's display too big for current implementation of the driver? Also, there seems to be no display reset/clear mechanic yet. How would I refresh the display in some other ways? Thank you in advance for looking into this, here is the relevant repository:
https://github.com/sambenko/esp32s3-box-lite-devicescript-display

[pelikhan]

@mmoskal

[mmoskal]

Unfortunately, we set maximum allocation size to 0xe000; It's possible it could be closer to 0xffff, but either way it's not enough for your screen. The allocation size is set so that we can use uint16_t as size of various buffers, so it's not easy to increase past 0xffff... :/

[mmoskal]

Actually, I take that back - we're using 4bpp so the screen should fit.

Check out esp32 v2.15.1500 when it builds.

[sambenko]

Hello, sorry for the late reply, I was sick for a week. I'm not really sure what to do, I checked this https://github.com/microsoft/devicescript-esp32/releases/tag/v2.15.1500, not sure what to go off of next.
Doesn't 4bpp mean that more space needs to be alocated for each pixel? @mmoskal

[pelikhan]

Let me push a release and you’ll be able to reflash the ESP32 firmware to get this fix.

…

________________________________ From: sambenko ***@***.***> Sent: Friday, October 27, 2023 8:22:00 AM To: microsoft/devicescript ***@***.***> Cc: Peli de Halleux ***@***.***>; Comment ***@***.***> Subject: Re: [microsoft/devicescript] RangeError when trying to initialise display on my ESP32S3-BOX-LITE devkit (Discussion #649) Hello, sorry for the late reply, I was sick for a week. I'm not really sure what to do, I checked this https://github.com/microsoft/devicescript-esp32/releases/tag/v2.15.1500, not sure what to go off of next. — Reply to this email directly, view it on GitHub<#649 (reply in thread)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AA73QKP366BV4XJZJYIPAU3YBPGRRAVCNFSM6AAAAAA6HMKEI2VHI2DSMVQWIX3LMV43SRDJONRXK43TNFXW4Q3PNVWWK3TUHM3TIMBVGA2TQ>. You are receiving this because you commented.Message ID: ***@***.***>

[sambenko]

Thank you, updating to the latest release works for the display size of 320x240 now!

[pelikhan]

[celebrate] Peli de Halleux reacted to your message:

…

________________________________ From: sambenko ***@***.***> Sent: Saturday, October 28, 2023 6:59:39 PM To: microsoft/devicescript ***@***.***> Cc: Peli de Halleux ***@***.***>; Comment ***@***.***> Subject: Re: [microsoft/devicescript] RangeError when trying to initialise display on my ESP32S3-BOX-LITE devkit (Discussion #649) Thank you, updating to the latest release works for the display size of 320x240 now! — Reply to this email directly, view it on GitHub<#649 (reply in thread)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AA73QKORA6XRVA7YD4LTRQDYBVIZXAVCNFSM6AAAAAA6HMKEI2VHI2DSMVQWIX3LMV43SRDJONRXK43TNFXW4Q3PNVWWK3TUHM3TIMJSG42TQ>. You are receiving this because you commented.Message ID: ***@***.***>

[aeroniemi]

I've got a similar issue trying to allocate a 320x240x4 image on a pi pico-w - is this a fix that it'll be possible to apply to RP2040?

[mmoskal]

I've just bumped devicescript version in the pico port, so firmware v2.15.1900 for pico should have it fixed!

[pelikhan]

#663