Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release notes for .NET UWP 6.0.2 #568

Merged
merged 4 commits into from
Nov 22, 2017
Merged

Add release notes for .NET UWP 6.0.2 #568

merged 4 commits into from
Nov 22, 2017

Conversation

HollyAM
Copy link
Contributor

@HollyAM HollyAM commented Nov 21, 2017

No description provided.

- Fixes an issue when building UWP apps that target RS3 and referenced the Microsoft Store Services SDK and Microsoft Advertising SDK or Store Engagement SDK [514498]
- Fixes Crashes due to an error in the compiler's garbage collection reporting (affects ARM apps built with .NET Native) [507618]
- Improves performance for creating new New UWP Projects. [512775]
- Fixes issues that enable Windows Application Packaging (Centennial) projects publishing scenarios [521438]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like we should leave out the Windows Application Packaging mention since that hasn't publicly RTM'ed yet.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a preview or any other public release? If not, I will remove this.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's currently in VS previews, but it will RTM with the next VS release

Copy link

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left some nits about casing and tense, @HollyAM

### UWP 6.0.2 (.NET Native 2.0.1) (November 20, 2017)

#### Quality fixes
- Fixes an issue when building UWP apps that target RS3 and referenced the Microsoft Store Services SDK and Microsoft Advertising SDK or Store Engagement SDK [514498]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

referenced --> reference

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

double space between SDK andMicrosoft Advertising...


#### Quality fixes
- Fixes an issue when building UWP apps that target RS3 and referenced the Microsoft Store Services SDK and Microsoft Advertising SDK or Store Engagement SDK [514498]
- Fixes Crashes due to an error in the compiler's garbage collection reporting (affects ARM apps built with .NET Native) [507618]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crashes --> crashes

#### Quality fixes
- Fixes an issue when building UWP apps that target RS3 and referenced the Microsoft Store Services SDK and Microsoft Advertising SDK or Store Engagement SDK [514498]
- Fixes Crashes due to an error in the compiler's garbage collection reporting (affects ARM apps built with .NET Native) [507618]
- Improves performance for creating new New UWP Projects. [512775]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new New UWP Projects --> new UWP projects

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional comment: This particular fix was related to VS installation which users wouldn't get from NuGet, so I'm not sure we should advertise it as a UWP 6.0.2 fix.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If someone installed UWP 6.0.2 on VS 15.4, will they see this fix? If so, I think we should include it. Also, I don't plan to write unique release notes for VS, so I wan to include it.

- Fixes Crashes due to an error in the compiler's garbage collection reporting (affects ARM apps built with .NET Native) [507618]
- Improves performance for creating new New UWP Projects. [512775]
- Fixes issues that enable Windows Application Packaging (Centennial) projects publishing scenarios [521438]
- Enables a P/Invoke feature for WindowsSDK Store in RS3 [518300]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although this fix unblocked developers, the issue was internal-facing so I would propose excluding this line.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new New, maybe just New?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zamont, Since I already have it down, I am not going to remove it. I am in favor of transparency in general, though per our offline conversation, I can see how in the future it may not make sense to document these kind of fixes that shouldn't be noticeable to developers.

@lt72
Copy link
Contributor

lt72 commented Nov 21, 2017

👍

@richlander
Copy link
Member

LGTM

@HollyAM
Copy link
Contributor Author

HollyAM commented Nov 22, 2017

@richlander or @rpetrusha, Can you merge this? I believe all of the feedback has been addressed and I don't have permission.

@lt72 lt72 merged commit 82d5fe0 into microsoft:master Nov 22, 2017
@lt72
Copy link
Contributor

lt72 commented Nov 22, 2017

Merged.

@HollyAM
Copy link
Contributor Author

HollyAM commented Nov 22, 2017

Thank you! I though you weren't working today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants