-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add release notes for .NET UWP 6.0.2 #568
Conversation
releases/UWP/net-native2.0/README.md
Outdated
- Fixes an issue when building UWP apps that target RS3 and referenced the Microsoft Store Services SDK and Microsoft Advertising SDK or Store Engagement SDK [514498] | ||
- Fixes Crashes due to an error in the compiler's garbage collection reporting (affects ARM apps built with .NET Native) [507618] | ||
- Improves performance for creating new New UWP Projects. [512775] | ||
- Fixes issues that enable Windows Application Packaging (Centennial) projects publishing scenarios [521438] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like we should leave out the Windows Application Packaging mention since that hasn't publicly RTM'ed yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a preview or any other public release? If not, I will remove this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's currently in VS previews, but it will RTM with the next VS release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left some nits about casing and tense, @HollyAM
releases/UWP/net-native2.0/README.md
Outdated
### UWP 6.0.2 (.NET Native 2.0.1) (November 20, 2017) | ||
|
||
#### Quality fixes | ||
- Fixes an issue when building UWP apps that target RS3 and referenced the Microsoft Store Services SDK and Microsoft Advertising SDK or Store Engagement SDK [514498] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
referenced --> reference
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
double space between SDK andMicrosoft Advertising...
releases/UWP/net-native2.0/README.md
Outdated
|
||
#### Quality fixes | ||
- Fixes an issue when building UWP apps that target RS3 and referenced the Microsoft Store Services SDK and Microsoft Advertising SDK or Store Engagement SDK [514498] | ||
- Fixes Crashes due to an error in the compiler's garbage collection reporting (affects ARM apps built with .NET Native) [507618] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Crashes --> crashes
releases/UWP/net-native2.0/README.md
Outdated
#### Quality fixes | ||
- Fixes an issue when building UWP apps that target RS3 and referenced the Microsoft Store Services SDK and Microsoft Advertising SDK or Store Engagement SDK [514498] | ||
- Fixes Crashes due to an error in the compiler's garbage collection reporting (affects ARM apps built with .NET Native) [507618] | ||
- Improves performance for creating new New UWP Projects. [512775] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new New UWP Projects --> new UWP projects
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional comment: This particular fix was related to VS installation which users wouldn't get from NuGet, so I'm not sure we should advertise it as a UWP 6.0.2 fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If someone installed UWP 6.0.2 on VS 15.4, will they see this fix? If so, I think we should include it. Also, I don't plan to write unique release notes for VS, so I wan to include it.
releases/UWP/net-native2.0/README.md
Outdated
- Fixes Crashes due to an error in the compiler's garbage collection reporting (affects ARM apps built with .NET Native) [507618] | ||
- Improves performance for creating new New UWP Projects. [512775] | ||
- Fixes issues that enable Windows Application Packaging (Centennial) projects publishing scenarios [521438] | ||
- Enables a P/Invoke feature for WindowsSDK Store in RS3 [518300] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although this fix unblocked developers, the issue was internal-facing so I would propose excluding this line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new New, maybe just New?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zamont, Since I already have it down, I am not going to remove it. I am in favor of transparency in general, though per our offline conversation, I can see how in the future it may not make sense to document these kind of fixes that shouldn't be noticeable to developers.
👍 |
LGTM |
@richlander or @rpetrusha, Can you merge this? I believe all of the feedback has been addressed and I don't have permission. |
Merged. |
Thank you! I though you weren't working today. |
No description provided.