-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add request types to allow for mediator pattern invocation of tasks #121
Open
jviau
wants to merge
13
commits into
microsoft:main
Choose a base branch
from
jviau:mediator
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the mediator pattern for invoking of orchestrations and activities. This allows for users to invoke activities and orchestrations via strongly-typed request objects and also to build up complex invocation patterns through additional
TaskOrchestrationContext
extension methods and more derived request types. Some examples would be:ILongRuningActivityRequest<TResult>
and aRunAsync
extension method for it which will handle enqueuing a polling orchestration and polling activity.AsyncPageable<T>
classes to allow for paging over activities viaIAsyncEnumerable<T>
in your code.This will also replace the code-generation approach for strongly typed orchestration/activity invocations. In my opinion, I prefer this route over code-generation. It is more flexible and avoids function-name conflicts. We can still explore how we can leverage code-generation to add value to this pattern though - but it will always be an optional addition.
resolves #73
TODO:
DurableTaskClient
extension method for enqueuing orchestrations.