Refactor to use primary constructors from .net8 #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgillum
reviewed
Apr 4, 2024
cgillum
reviewed
Apr 4, 2024
cgillum
reviewed
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors to use primary constructors when possible. There are several instances of removing the field and
this.accessors as I am switching to rely on primary ctor closure (let the compiler decide how to capture and store those fields given by the ctor when possible). I only do this when arg checking is not needed (will already be checked before ctor or is not production code).Some additional refactor changes in this PR: removing unused fields/properties (we can add them back in when/if needed).