Fix swallowed exception - Improve output exception message #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaibocai
requested review from
cgillum and
shreyas-gopalakrishna
as code owners
cgillum
reviewed
Nov 20, 2023
client/src/main/java/com/microsoft/durabletask/TaskOrchestrationExecutor.java
Outdated
Show resolved
Hide resolved
cgillum
reviewed
Nov 22, 2023
...va/com/microsoft/durabletask/azurefunctions/internal/middleware/OrchestrationMiddleware.java
Show resolved
Hide resolved
client/src/main/java/com/microsoft/durabletask/TaskOrchestrationExecutor.java
Outdated
Show resolved
Hide resolved
samples-azure-functions/src/main/java/com/functions/DeserializeError.java
Outdated
Show resolved
Hide resolved
cgillum
reviewed
Nov 27, 2023
samples-azure-functions/src/main/java/com/functions/AzureFunctions.java
Outdated
Show resolved
Hide resolved
update changelog fix same issue for handleTaskCompleted, handleSubOrchestrationCompleted improve the example and e2e tests
kaibocai
force-pushed
the
kaibocai/issue-184
branch
from
4f90d90 to
e85dc47
Compare
cgillum
reviewed
Nov 29, 2023
samples-azure-functions/src/main/java/com/functions/SubOrchestrator.java
Outdated
Show resolved
Hide resolved
samples-azure-functions/src/main/java/com/functions/WaitExternalEvent.java
Outdated
Show resolved
Hide resolved
samples-azure-functions/src/main/java/com/functions/WaitExternalEvent.java
Outdated
Show resolved
Hide resolved
cgillum
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
resolves #184.
This PR fix the deserialized exception swallowed issue and improve the exception message in the final output to help customers better understand the exception.
Pull request checklist
CHANGELOG.mdAdditional information
Additional PR information