Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update readme adding instructions for local setup #191

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kaibocai
Copy link
Member

Issue describing the changes in this PR

This PR updates readme adding instructions for local setup

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes are added to the CHANGELOG.md
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

@kaibocai
Copy link
Member Author

cc @skyao

One thing to note in the local setup:

Replace the variable at https://github.com/microsoft/durabletask-java/blob/b3e2d3ab9dfc07495f830d90b00d7fac35009ea0/client/build.gradle#L20
with your local `$JAVA_HOME`, the version needs to be equal or higher than Java11 for example:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't the build.gradle script just do this automatically? Why doesn't it use $JAVA_HOME today?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants