XForm: Cleanup.

  - CodeFormat pass.
  - Added copyright comment to native code.
  - Remove unused and misspelled variable from TableTestHarness.

Elfie/Elfie/Model/Strings/String8.cs

@@ -1464,7 +1464,7 @@ public bool Equals(String8 other)
 
             int offset = other.Index - this.Index;
             int end = this.Index + this.Length;
-            for(int i = this.Index; i < end; ++i)
+            for (int i = this.Index; i < end; ++i)
             {
                 if (this.Array[i] != other.Array[i + offset]) return false;
             }

XForm/XForm.Generator/Model/WebRequestDisasters.cs

@@ -1,4 +1,7 @@
-using System;
+// Copyright (c) Microsoft. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+
+using System;
 
 namespace XForm.Generator.Model
 {
@@ -17,7 +20,7 @@ public DataCenterOutage(DateTime startTime, DateTime endTime, string dataCenter)
         {
             this.StartTime = startTime;
             this.EndTime = endTime;
-            this.DataCenter = dataCenter    ;
+            this.DataCenter = dataCenter;
         }
 
         public void Transform(WebRequest item)
@@ -107,5 +110,4 @@ public void Transform(WebRequest item)
             }
         }
     }
-
 }

XForm/XForm.Generator/Program.cs

@@ -70,7 +70,7 @@ private static void Generate_WebRequestSample(string basePath, int randomSeed, i
             for (int day = 0; day < numberOfDays; ++day)
             {
                 generator = new WebRequestGenerator(users, r, asOfDate, (eventCount < 1001 ? 10 : 100));
-                if(day == 0) generator.Issue = new PremiumUserOutage(asOfDate.AddMinutes(18), asOfDate.AddMinutes(104), r);
+                if (day == 0) generator.Issue = new PremiumUserOutage(asOfDate.AddMinutes(18), asOfDate.AddMinutes(104), r);
                 BuildWebRequests(basePath, generator, eventCount, WebRequestWriteMode.UserIdentityOnly);
                 asOfDate = asOfDate.AddDays(-1);
             }

XForm/XForm.Native/BitVectorN.cpp

@@ -1,3 +1,6 @@
+// Copyright (c) Microsoft. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+
 #include "stdafx.h"
 #include <intrin.h>
 #include <nmmintrin.h>

XForm/XForm.Native/BitVectorN.h

@@ -1,3 +1,6 @@
+// Copyright (c) Microsoft. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+
 #pragma once
 using namespace System;
 

XForm/XForm.Native/Comparer.h

@@ -1,3 +1,6 @@
+// Copyright (c) Microsoft. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+
 #pragma once
 using namespace System;
 

XForm/XForm.Native/Comparer16.cpp

@@ -1,3 +1,6 @@
+// Copyright (c) Microsoft. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+
 #include "stdafx.h"
 #include <intrin.h>
 #include <nmmintrin.h>

XForm/XForm.Native/Comparer8.cpp

@@ -1,3 +1,6 @@
+// Copyright (c) Microsoft. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+
 #include "stdafx.h"
 #include <intrin.h>
 #include <nmmintrin.h>

XForm/XForm.Native/ComparerSingle.cpp

@@ -1,3 +1,6 @@
+// Copyright (c) Microsoft. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+
 #include "stdafx.h"
 #include <intrin.h>
 #include <nmmintrin.h>

XForm/XForm.Native/Operator.h

@@ -1,3 +1,6 @@
+// Copyright (c) Microsoft. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+
 #pragma once
 
 // WARNING: Values must stay in sync with XForm.Query.Operator

XForm/XForm.Native/String8N.cpp

@@ -1,3 +1,6 @@
+// Copyright (c) Microsoft. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+
 #include "stdafx.h"
 #include <intrin.h>
 #include <nmmintrin.h>

XForm/XForm.Native/String8N.h

@@ -1,3 +1,6 @@
+// Copyright (c) Microsoft. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+
 #pragma once
 using namespace System;
 

XForm/XForm.Test/AssertCommand.cs

@@ -1,9 +1,10 @@
 // Copyright (c) Microsoft. All rights reserved.
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
-using Microsoft.VisualStudio.TestTools.UnitTesting;
 using System.Threading;
 
+using Microsoft.VisualStudio.TestTools.UnitTesting;
+
 using XForm.Data;
 using XForm.Extensions;
 using XForm.Query;

XForm/XForm.Test/Core/SamplerTests.cs

@@ -1,5 +1,10 @@
-using Microsoft.VisualStudio.TestTools.UnitTesting;
+// Copyright (c) Microsoft. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+
 using System;
+
+using Microsoft.VisualStudio.TestTools.UnitTesting;
+
 using XForm.Core;
 using XForm.Data;
 

XForm/XForm.Test/IO/VariableIntegerReaderWriterTests.cs

@@ -1,13 +1,13 @@
 // Copyright (c) Microsoft. All rights reserved.
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
+using System.IO;
 using System.Linq;
 
 using Microsoft.VisualStudio.TestTools.UnitTesting;
 
 using XForm.Data;
 using XForm.IO;
-using System.IO;
 using XForm.Types;
 
 namespace XForm.Test.IO

XForm/XForm.Test/Query/XTableBasicTests.cs

@@ -1,10 +1,12 @@
 // Copyright (c) Microsoft. All rights reserved.
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
+using System.Threading;
+
 using Elfie.Test;
 
 using Microsoft.VisualStudio.TestTools.UnitTesting;
-using System.Threading;
+
 using XForm.Data;
 using XForm.Extensions;
 using XForm.Query;

XForm/XForm.Test/TableTestHarness.cs

@@ -32,8 +32,6 @@ public static XDatabaseContext DatabaseContext
             }
         }
 
-        public static object Strnig8Block { get; private set; }
-
         public static void AssertAreEqual(IXTable expected, IXTable actual, int pageSize)
         {
             // Reset both tables (so they can be used for repeated scenarios)
@@ -107,10 +105,10 @@ public static void AssertAreEqual(IXTable expected, IXTable actual, int pageSize
                         XArray actualArray = actualArrays[i].Slice(actualNextIndex, actualNextIndex + countToCompare);
 
                         firstMismatchedRow = FirstMismatchedRow(
-                            expectedArray, 
-                            actualArray, 
-                            countToCompare, 
-                            expected.Columns[i].ColumnDetails.Name, 
+                            expectedArray,
+                            actualArray,
+                            countToCompare,
+                            expected.Columns[i].ColumnDetails.Name,
                             out errorMessage);
 
                         if (!String.IsNullOrEmpty(errorMessage)) break;
@@ -290,7 +288,7 @@ public static String8[] ToString8(String[] values)
             String8Block block = new String8Block();
 
             String8[] result = new String8[values.Length];
-            for(int i = 0; i < values.Length; ++i)
+            for (int i = 0; i < values.Length; ++i)
             {
                 result[i] = block.GetCopy(values[i]);
             }

XForm/XForm/Aggregators/CountAggregator.cs

@@ -20,7 +20,7 @@ public class CountAggregator : IAggregator, IFoundIndicesTracker
     {
         private int[] _countPerBucket;
         private int _distinctCount;
-        
+
         public CountAggregator()
         {
             ColumnDetails = new ColumnDetails("Count", typeof(int));

XForm/XForm/Aggregators/PercentageAggregator.cs

@@ -99,7 +99,7 @@ public static string WholePercentage(int count, int total)
             if (count == total) return "100%";
 
             float percentage = (float)count / (float)total;
-            return percentage.ToString("p0"); 
+            return percentage.ToString("p0");
         }
 
         public void Add(XArray rowIndices, int newDistinctCount)

XForm/XForm/Aggregators/SumAggregator.cs

@@ -2,6 +2,7 @@
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
 using System;
+
 using XForm.Columns;
 using XForm.Data;
 

XForm/XForm/Core/Sampler.cs

@@ -1,4 +1,8 @@
-using System;
+// Copyright (c) Microsoft. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+
+using System;
+
 using XForm.Data;
 
 namespace XForm.Core

XForm/XForm/Extensions/XTableExtensions.cs

@@ -5,6 +5,7 @@
 using System.Collections.Generic;
 using System.Diagnostics;
 using System.Threading;
+
 using XForm.Data;
 using XForm.IO;
 using XForm.IO.StreamProvider;
@@ -112,7 +113,7 @@ public static RunResult RunUntilTimeout(this IXTable pipeline, TimeSpan timeout,
             using (CancellationTokenSource source = new CancellationTokenSource())
             {
                 CancellationToken cancellationToken = source.Token;
-                if(timeout != TimeSpan.Zero && timeout != TimeSpan.MaxValue) source.CancelAfter(timeout);
+                if (timeout != TimeSpan.Zero && timeout != TimeSpan.MaxValue) source.CancelAfter(timeout);
 
                 RunResult result = new RunResult();
                 result.Timeout = timeout;
@@ -123,7 +124,7 @@ public static RunResult RunUntilTimeout(this IXTable pipeline, TimeSpan timeout,
                     int count = pipeline.Next(batchSize, cancellationToken);
                     result.RowCount += count;
 
-                    if(cancellationToken.IsCancellationRequested)
+                    if (cancellationToken.IsCancellationRequested)
                     {
                         break;
                     }

XForm/XForm/Functions/IsNull.cs

@@ -1,4 +1,8 @@
-using System;
+// Copyright (c) Microsoft. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+
+using System;
+
 using XForm.Data;
 
 namespace XForm.Functions

XForm/XForm/IO/TabularFileWriter.cs

@@ -4,14 +4,14 @@
 using System;
 using System.Collections.Generic;
 using System.Linq;
+using System.Threading;
 
 using Microsoft.CodeAnalysis.Elfie.Model.Strings;
 using Microsoft.CodeAnalysis.Elfie.Serialization;
 
 using XForm.Data;
 using XForm.IO.StreamProvider;
 using XForm.Types;
-using System.Threading;
 
 namespace XForm.IO
 {

XForm/XForm/IO/VariableIntegerReaderWriter.cs

@@ -1,4 +1,8 @@
-using System;
+// Copyright (c) Microsoft. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+
+using System;
+
 using XForm.Data;
 using XForm.IO.StreamProvider;
 using XForm.Types;
@@ -143,7 +147,7 @@ public void Append(XArray xarray)
 
         public void Dispose()
         {
-            if(_writer != null)
+            if (_writer != null)
             {
                 _writer.Dispose();
                 _writer = null;
@@ -165,7 +169,7 @@ public VariableIntegerReader(IStreamProvider streamProvider, string columnPathPr
             // Look for each potential size in descending order and build the right reader and converter
             Type type = typeof(int);
             string path = VariableIntegerWriter.PathForType(columnPathPrefix, typeof(int));
-            if(streamProvider.Attributes(path).Exists)
+            if (streamProvider.Attributes(path).Exists)
             {
                 _reader = TypeProviderFactory.TryGetColumnReader(streamProvider, typeof(int), path, option, typeof(VariableIntegerReader));
                 _converter = null;
@@ -197,7 +201,7 @@ public XArray Read(ArraySelector selector)
 
         public void Dispose()
         {
-            if(_reader != null)
+            if (_reader != null)
             {
                 _reader.Dispose();
                 _reader = null;

XForm/XForm/Verbs/Peek.cs

@@ -1,11 +1,12 @@
 // Copyright (c) Microsoft. All rights reserved.
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
-using Microsoft.CodeAnalysis.Elfie.Model.Strings;
 using System;
 using System.Collections.Generic;
 using System.Threading;
 
+using Microsoft.CodeAnalysis.Elfie.Model.Strings;
+
 using XForm.Aggregators;
 using XForm.Columns;
 using XForm.Core;
@@ -101,7 +102,7 @@ private void PostSortAndFilter(XArray groups, XArray counts, int totalRowCount,
             for (int i = 0; i < groups.Count; ++i)
             {
                 int count = countsArray[counts.Index(i)];
-                if(count >= threshold)
+                if (count >= threshold)
                 {
                     finalIndices[groupCount] = i;
                     finalCounts[groupCount] = count;
@@ -168,7 +169,7 @@ private void BuildDictionary(CancellationToken cancellationToken)
             Random r = new Random();
 
             // Build a Dictionary and CountAggregator for each sample
-            GroupByDictionary[] dictionaries = new GroupByDictionary[SampleCount]; 
+            GroupByDictionary[] dictionaries = new GroupByDictionary[SampleCount];
             CountAggregator[] counts = new CountAggregator[SampleCount];
             int[][] remapArrays = new int[SampleCount][];
             for (int i = 0; i < SampleCount; ++i)