This repository has been archived by the owner on Feb 15, 2022. It is now read-only.
Leverage Existing Helm Repo #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ead of creating a temp one.
|
|
evanlouie
suggested changes
Sep 12, 2019
There was a problem hiding this comment.
Hi @runyontr! Thanks for the PR :)
Liking the proposed changes. Just a couple of minor requests around documentation/logging.
Couple of things that would be really appreciated:
- Adding a snippet to https://github.com/microsoft/fabrikate/blob/master/docs/auth.md as well explaining the use case and how it works.
- Adding a test for this use-case.
evanlouie
approved these changes
Oct 30, 2019
|
Thanks for your contribution @runyontr! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a repo already installed into the
helm repo list, the cli will now use that reference instead of creating a new temp repo.Closes #259