Skip to content

Commit

Permalink
Fix a dependency issue with express open redirect vulnerability (#7003)
Browse files Browse the repository at this point in the history
# Pull Request

## 📖 Description

This fixes a vulnerability with express for open redirects.

## 👩‍💻 Reviewer Notes

The SSR test site is not exposed publicly, nevertheless to close out some vulnerability alerts this change was made.

## ✅ Checklist

### General

<!--- Review the list and put an x in the boxes that apply. -->

- [ ] I have included a change request file using `$ npm run change`
- [ ] I have added tests for my changes.
- [x] I have tested my changes.
- [ ] I have updated the project documentation to reflect my changes.
- [x] I have read the [CONTRIBUTING](https://github.com/microsoft/fast/blob/master/CONTRIBUTING.md) documentation and followed the [standards](https://github.com/microsoft/fast/blob/master/CODE_OF_CONDUCT.md#our-standards) for this project.
  • Loading branch information
janechu authored Jul 19, 2024
1 parent 035aefc commit 02762ac
Show file tree
Hide file tree
Showing 4 changed files with 26 additions and 18 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "Fix a dependency issue with express open redirect vulnerability",
"packageName": "@microsoft/fast-ssr",
"email": "7559015+janechu@users.noreply.github.com",
"dependentChangeType": "none"
}
2 changes: 1 addition & 1 deletion examples/ssr/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"@microsoft/fast-element": "^2.0.0-beta.26",
"@microsoft/fast-foundation": "^3.0.0-alpha.33",
"@microsoft/fast-ssr": "^1.0.0-beta.33",
"express": "^4.18.1",
"express": "^4.19.2",
"fast-todo-app": "1.0.0",
"ts-loader": "^9.3.0",
"tslib": "^2.6.3",
Expand Down
31 changes: 16 additions & 15 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions packages/web-components/fast-ssr/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,9 @@
"@microsoft/fast-foundation": "^3.0.0-alpha.33",
"@microsoft/api-extractor": "^7.47.0",
"@playwright/test": "^1.41.2",
"@types/express": "^4.17.13",
"@types/express": "^4.17.21",
"@types/node": "^17.0.17",
"express": "^4.17.1",
"express": "^4.19.2",
"typescript": "~5.3.0"
}
}

0 comments on commit 02762ac

Please sign in to comment.