Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: picker zero selection #6780

Merged
merged 5 commits into from
Aug 8, 2023
Merged

feat: picker zero selection #6780

merged 5 commits into from
Aug 8, 2023

Conversation

scomea
Copy link
Collaborator

@scomea scomea commented Jul 13, 2023

📖 Description

This change modifies Picker's behavior when the maximum number of selected items is 0. In that case selecting an item in the menu won't add a selected item but instead just updates the query string to match for a more combo-box like behavior but with Picker's "loading" and "no-suggestions" pop-ups.

✅ Checklist

General

  • I have included a change request file using $ yarn change
  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

@chrisdholt chrisdholt merged commit e0d4cb4 into master Aug 8, 2023
5 checks passed
@chrisdholt chrisdholt deleted the users/scomea/picker-zero branch August 8, 2023 17:18
janechu pushed a commit that referenced this pull request Jun 10, 2024
* picker zero items

* Change files

* prettier

* default to null

* update files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants