fix: Suggested Rollup config corrupts output html #6795
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timfish
requested review from
awentzel,
chrisdholt,
Falkicon and
EisenbergEffect
as code owners
|
There are probably still some improvements to be had with the css regex since the output still has some unnessary spaces: 
|
|
The css regex in fast/build/transform-fragments.js Line 31 in 50dba9c So it would become:
Shall I create a PR for that first? |
janechu
added a commit
that referenced
this pull request
Jun 11, 2024
# Pull Request ## 📖 Description The rollup configuration docs for FAST Element v1 cause corrupted HTML, this change ports over validated configuration options used in Fluent UI web components. ### 🎫 Issues Closes #6795 ## ✅ Checklist ### General <!--- Review the list and put an x in the boxes that apply. --> - [ ] I have included a change request file using `$ yarn change` - [ ] I have added tests for my changes. - [ ] I have tested my changes. - [x] I have updated the project documentation to reflect my changes. - [x] I have read the [CONTRIBUTING](https://github.com/microsoft/fast/blob/master/CONTRIBUTING.md) documentation and followed the [standards](https://github.com/microsoft/fast/blob/master/CODE_OF_CONDUCT.md#our-standards) for this project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
I found that the suggested Rollup config results in corrupted html:
In the output bundle you can see the missing space:
I tied these regexes and they fix the issue:
https://github.com/microsoft/fast/blob/50dba9c58b1bc6ac0c8b948f68dd0cfb6485460b/build/transform-fragments.js
$ yarn change