Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependency injection documentation #6978

Merged
merged 7 commits into from
Jun 13, 2024
Merged

Conversation

janechu
Copy link
Collaborator

@janechu janechu commented Jun 6, 2024

Pull Request

πŸ“– Description

This change fills out the dependency injection documentation with some examples, for regular JavaScript and dependency injection for web components.

πŸ‘©β€πŸ’» Reviewer Notes

The document does not contain an exhaustive list of all the capabilities of our current dependency injection utilities. We will be adding generated API documentation for this, and all other specific exports for users to refer to. See #6979

βœ… Checklist

General

  • I have included a change request file using $ yarn change
  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

⏭ Next Steps

  • Add api-extractor generated documentation for all named exports.

Copy link
Collaborator

@KingOfTac KingOfTac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Just had one comment.

sites/website/src/docs/advanced/dependency-injection.md Outdated Show resolved Hide resolved
janechu and others added 2 commits June 7, 2024 12:45
Co-authored-by: Nicholas Rice <3213292+nicholasrice@users.noreply.github.com>
@janechu janechu self-assigned this Jun 12, 2024
@janechu janechu merged commit 8ba27ed into master Jun 13, 2024
10 checks passed
@janechu janechu deleted the users/janechu/add-di-doc branch June 13, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants