-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Flaky History Test #3887
Merged
Merged
Fix Flaky History Test #3887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikaelweave
added
Open source
This change is only relevant to the OSS code or release.
Bug
Bug bug bug.
labels
May 30, 2024
SergeyGaluzo
previously approved these changes
May 30, 2024
SergeyGaluzo
previously approved these changes
May 30, 2024
test/Microsoft.Health.Fhir.Shared.Tests.E2E/Rest/HistoryTests.cs
Dismissed
Show dismissed
Hide dismissed
test/Microsoft.Health.Fhir.Shared.Tests.E2E/Rest/HistoryTests.cs
Dismissed
Show dismissed
Hide dismissed
SergeyGaluzo
approved these changes
May 30, 2024
fhibf
approved these changes
May 30, 2024
LTA-Thinking
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The test
GivenTestResourcesWithUpdatesAndDeletes_WhenGettingResourceHistoryCount_TheServerShouldReturnCorrectCount
is behaving flakily and blocking PRs from executing for others devs. Changing the way it finds history for more reliability.Related issues
AB#121007
Testing
Describe how this change was tested.
FHIR Team Checklist
Semver Change (docs)
Patch|Skip|Feature|Breaking (reason)