Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue reindex when encountering empty page #4627

Merged
merged 8 commits into from
Sep 20, 2024

Conversation

mikaelweave
Copy link
Contributor

@mikaelweave mikaelweave commented Sep 18, 2024

Description

Changes reindex to continue when encountering empty pages for a given surrogate id range.

Since empty pages are rare, kept current behavior to only get one page range at once.

Related issues

AB#124883

Testing

Integration Test.

FHIR Team Checklist

  • Update the title of the PR to be succinct and less than 65 characters
  • Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
  • Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
  • Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
  • Tag the PR with Schema Version backward compatible or Schema Version backward incompatible or Schema Version unchanged if this adds or updates Sql script which is/is not backward compatible with the code.
  • CI is green before merge Build Status
  • Review squash-merge requirements

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)

@mikaelweave mikaelweave added Bug Bug bug bug. Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs labels Sep 18, 2024
@mikaelweave mikaelweave added this to the S150 milestone Sep 18, 2024
@mikaelweave mikaelweave requested a review from a team as a code owner September 18, 2024 20:07
Copy link
Contributor

@SergeyGaluzo SergeyGaluzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why get ranges call is in do loop?

SergeyGaluzo
SergeyGaluzo previously approved these changes Sep 20, 2024
@mikaelweave mikaelweave enabled auto-merge (squash) September 20, 2024 20:21
@mikaelweave mikaelweave merged commit 5f6c02c into main Sep 20, 2024
44 of 46 checks passed
@mikaelweave mikaelweave deleted the personal/mikaelw/fix-reindex-empty-pages branch September 20, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs Bug Bug bug bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants