Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document Update #4671

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Document Update #4671

merged 2 commits into from
Nov 19, 2024

Conversation

v-shnarang
Copy link
Contributor

@v-shnarang v-shnarang commented Oct 11, 2024 •
edited
Loading

Description

A note has been added to the default deployment document, specifying that the SQL migration tool should be run immediately after the deployment completes successfully, if the SQL database deployment has the Schema Update set to TOOL

Related issues

Addresses issue #130428.

Testing

Describe how this change was tested.

FHIR Team Checklist

  • Update the title of the PR to be succinct and less than 65 characters
  • Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
  • Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
  • Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
  • Tag the PR with Schema Version backward compatible or Schema Version backward incompatible or Schema Version unchanged if this adds or updates Sql script which is/is not backward compatible with the code.
  • CI is green before merge Build Status
  • Review squash-merge requirements

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)

@v-shnarang v-shnarang added the Documentation update request Tag created to update the documentation for Azure FHIR server label Oct 11, 2024
@v-shnarang v-shnarang added this to the S151 milestone Oct 11, 2024
@v-shnarang v-shnarang requested a review from a team as a code owner October 11, 2024 08:05
evachen96
evachen96 approved these changes Oct 14, 2024
View reviewed changes
Copy link

@evachen96 evachen96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, you can continue the process for merging the PR!

@evachen96 evachen96 linked an issue Oct 16, 2024 that may be closed by this pull request
Deployment Guide for Dummies #2207
Closed
@mikaelweave mikaelweave enabled auto-merge (squash) November 19, 2024 18:00
@mikaelweave
Copy link
Contributor

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mikaelweave mikaelweave merged commit c4a33cc into main Nov 19, 2024
44 of 45 checks passed
@mikaelweave mikaelweave deleted the personal/v-shnarang/docUpdate branch November 19, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evachen96 evachen96 evachen96 approved these changes

@brendankowitz brendankowitz brendankowitz approved these changes

Assignees
No one assigned
Labels
Documentation update request Tag created to update the documentation for Azure FHIR server
Projects
None yet
Milestone
S151
Development

Successfully merging this pull request may close these issues.

Deployment Guide for Dummies
4 participants
@v-shnarang @mikaelweave @brendankowitz @evachen96