Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

feat: add generateKey option to factories #3

Merged
merged 3 commits into from
Jul 20, 2018

Conversation

levithomason
Copy link
Member

@levithomason levithomason commented Jul 20, 2018

This PR pulls the latest autoGenerateKey factory option from SUIR. In doing so, I'll also create the specification for shorthand props and factories so we can discuss the pattern.

Rich history behind this is here: Semantic-Org/Semantic-UI-React#2418

@levithomason levithomason requested a review from dvdzkwsk as a code owner July 20, 2018 22:40
@levithomason levithomason changed the title sorry... feat: add generateKey option to factories Jul 20, 2018
@dvdzkwsk
Copy link
Contributor

Told ya so.

image

@dvdzkwsk
Copy link
Contributor

Lol, you are actually using this PR. I thought it was throwaway, lol...

@levithomason levithomason force-pushed the feat/factories-generate-key branch from 78f0f2c to 58f715e Compare July 20, 2018 22:54
@codecov
Copy link

codecov bot commented Jul 20, 2018

Codecov Report

Merging #3 into master will increase coverage by 14.26%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master       #3       +/-   ##
===========================================
+ Coverage    69.8%   84.06%   +14.26%     
===========================================
  Files          75       58       -17     
  Lines        1202      778      -424     
  Branches      228      157       -71     
===========================================
- Hits          839      654      -185     
+ Misses        358      120      -238     
+ Partials        5        4        -1
Impacted Files Coverage Δ
src/components/Accordion/Accordion.tsx 59.52% <ø> (ø) ⬆️
src/components/Header/Header.tsx 93.33% <100%> (ø) ⬆️
test/specs/commonTests/implementsCreateMethod.tsx
test/specs/commonTests/rendersChildren.tsx
test/specs/commonTests/implementsClassNameProps.ts
test/specs/commonTests/hasUIClassName.tsx
test/setup.ts
test/specs/commonTests/commonHelpers.ts
test/utils/consoleUtil.ts
test/specs/commonTests/classNameHelpers.tsx
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b7f612...16fc06a. Read the comment docs.

@levithomason levithomason merged commit c60dfd5 into master Jul 20, 2018
@levithomason levithomason deleted the feat/factories-generate-key branch July 20, 2018 23:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants