-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Avatar activity badge #1502
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a fair amount of binary size increase unaccounted for - do you know where the rest might be coming from? |
huwilkes
reviewed
Jan 20, 2023
ios/FluentUI.Demo/FluentUI.Demo/Demos/AvatarDemoController_SwiftUI.swift
Show resolved
Hide resolved
huwilkes
reviewed
Jan 20, 2023
huwilkes
reviewed
Jan 20, 2023
harrieshin
reviewed
Jan 20, 2023
ios/FluentUI.Demo/FluentUI.Demo/Demos/AvatarDemoController.swift
Outdated
Show resolved
Hide resolved
harrieshin
reviewed
Jan 20, 2023
harrieshin
reviewed
Jan 20, 2023
harrieshin
reviewed
Jan 20, 2023
edjamesmsft
reviewed
Jan 20, 2023
edjamesmsft
reviewed
Jan 20, 2023
huwilkes
reviewed
Jan 20, 2023
huwilkes
reviewed
Jan 20, 2023
sophialee0416
force-pushed
the
avatarActivity
branch
from
January 27, 2023 22:24
8c8dde4
to
9d0063c
Compare
sophialee0416
commented
Jan 27, 2023
harrieshin
reviewed
Jan 27, 2023
ios/FluentUI.Demo/FluentUI.Demo/Demos/AvatarDemoController.swift
Outdated
Show resolved
Hide resolved
harrieshin
reviewed
Jan 27, 2023
....Demo/FluentUI.Demo/Resources/Assets.xcassets/TableViewCell/excelIcon.imageset/Contents.json
Show resolved
Hide resolved
avatargroup animation verification? |
harrieshin
reviewed
Jan 27, 2023
huwilkes
reviewed
Jan 28, 2023
huwilkes
reviewed
Jan 28, 2023
huwilkes
reviewed
Jan 28, 2023
huwilkes
approved these changes
Jan 28, 2023
edjamesmsft
approved these changes
Jan 28, 2023
sophialee0416
force-pushed
the
avatarActivity
branch
from
January 28, 2023 00:49
682c8d5
to
fa68442
Compare
harrieshin
approved these changes
Jan 28, 2023
make sure the avatar rings are fine too for both avatargroup and just avatar please! |
11 tasks
This reverts commit 29750c8.
sophialee0416
force-pushed
the
avatarActivity
branch
from
January 30, 2023 18:57
0c30876
to
dd5d5c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
Binary change:
Note: Activity is only displayed in
.size40
and.size56
, and in the.default
style with image/initials.Verification
Presence (no change)
TableViewCell (no change)
AvatarGroup (no change)
Pull request checklist
This PR has considered:
Microsoft Reviewers: Open in CodeFlow