Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main_0.11] Cherry-picking: Removing unreadDot from height and width methods (#1514) #1516

Merged
merged 1 commit into from
Jan 25, 2023
Merged

[main_0.11] Cherry-picking: Removing unreadDot from height and width methods (#1514) #1516

merged 1 commit into from
Jan 25, 2023

Conversation

sophialee0416
Copy link
Contributor

@sophialee0416 sophialee0416 commented Jan 25, 2023 •
edited by microsoft-github-policy-service bot
Loading

Platforms Impacted

  • iOS
  • macOS

Description of changes

cherry picked from commit d1b93f8

Verification

Before After
image image
image image
image image
image image

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@sophialee0416 sophialee0416 requested a review from a team as a code owner January 25, 2023 22:28
@sophialee0416 sophialee0416 changed the base branch from main to main_0.11 January 25, 2023 22:28
@sophialee0416 sophialee0416 merged commit 1ad7ef7 into microsoft:main_0.11 Jan 25, 2023
@sophialee0416 sophialee0416 mentioned this pull request Jan 25, 2023
Merged
11 tasks
@sophialee0416 sophialee0416 deleted the cpTVC branch April 24, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harrieshin harrieshin harrieshin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sophialee0416 @harrieshin