Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BadgeView with Avatar to PeoplePicker demo page #1524

Merged

Conversation

joannaquu
Copy link
Contributor

@joannaquu joannaquu commented Jan 27, 2023

Platforms Impacted

  • iOS
  • macOS

Description of changes

Binary change:

File Before After Delta
libFluentUI.a 28,869,912 bytes 28,908,928 bytes 39,016 bytes

Added a new variant to the PeoplePicker demo page that displays badges with an Avatar. To do so, a new bool, showsAvatar was added that controls whether or not the avatar is shown. When showsAvatar is true, addBadge will be called with a PersonaBadgeViewDataSource that includes a customView (the avatar). When set to false, the existing addBadge call will be used. PersonaBadgeViewDataSource's init function now takes in an optional customView parameter that defaults to nil if no value is provided.

Verification

Before Light Dark
Simulator Screen Recording - iPhone 14 Pro - 2023-01-27 at 13 07 18 Simulator Screen Recording - iPhone 14 Pro - 2023-01-27 at 13 00 27 Simulator Screen Recording - iPhone 14 Pro - 2023-01-27 at 13 08 55

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@joannaquu joannaquu requested a review from a team as a code owner January 27, 2023 21:18
@joannaquu joannaquu merged commit 04af869 into microsoft:main Jan 27, 2023
@joannaquu joannaquu deleted the joannaqu/add-to-people-picker-demo branch January 27, 2023 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants