Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XCUITests] Notification View tests #1532

Merged

Conversation

joannaquu
Copy link
Contributor

@joannaquu joannaquu commented Jan 30, 2023

Platforms Impacted

  • iOS
  • macOS

Description of changes

Binary change:

File Before After Delta
libFluentUI.a 28,875,336 bytes 28,875,336 bytes 0 bytes

Added targeted UI tests for Notification View. An accessibility identifier was added to NotificationView in debug that tracks the Notification's title, message, image, action button, style, and flexibility (for toast notifications only). Tests were then designed to test each part of Notification View. For example, when show default dismiss button is enabled and there is no action button title, there should be a dismiss default button, if set trailing image is enabled and there is no action button title, there should be a trailing image, etc.

Verification

notification

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@joannaquu joannaquu requested a review from a team as a code owner January 30, 2023 22:10
@joannaquu joannaquu merged commit 44f2d10 into microsoft:main Feb 3, 2023
@joannaquu joannaquu deleted the joannaqu/notification-view-tests branch February 6, 2023 18:59
@harrieshin harrieshin mentioned this pull request Feb 14, 2023
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants