-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Badge in the BottomCommandingContoller demo page #1542
Merged
joannaquu
merged 7 commits into
microsoft:main
from
joannaquu:joannaqu/add-to-bottom-commanding-demo
Feb 8, 2023
Merged
Support Badge in the BottomCommandingContoller demo page #1542
joannaquu
merged 7 commits into
microsoft:main
from
joannaquu:joannaqu/add-to-bottom-commanding-demo
Feb 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
harrieshin
reviewed
Feb 3, 2023
ios/FluentUI/Bottom Commanding/BottomCommandingController.swift
Outdated
Show resolved
Hide resolved
harrieshin
reviewed
Feb 3, 2023
ios/FluentUI.Demo/FluentUI.Demo/Demos/BottomCommandingDemoController.swift
Show resolved
Hide resolved
edjamesmsft
reviewed
Feb 7, 2023
harrieshin
reviewed
Feb 7, 2023
harrieshin
reviewed
Feb 7, 2023
…oannaquu/fluentui-apple into joannaqu/add-to-bottom-commanding-demo
harrieshin
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
Binary change:
Added new item in
BottomCommandingContoller
demo page that supports a Badge. To do so,CommandingItem
was updated to have a new convenience init that takes in an optional badge. This badge is then provided toTableViewCell
'scustomAccessoryView
. AlthoughBadgeView
is aUIView
, using badge directly withcustomAccessoryView
did not work so the work around was to add it to aUIStackView
first.Verification
Pull request checklist
This PR has considered:
Microsoft Reviewers: Open in CodeFlow