Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Badge in the BottomCommandingContoller demo page #1542

Merged

Conversation

joannaquu
Copy link
Contributor

@joannaquu joannaquu commented Feb 3, 2023

Platforms Impacted

  • iOS
  • macOS

Description of changes

Binary change:

File Before After Delta
libFluentUI.a 28,869,912 bytes 28,927,608 bytes 57,696 bytes

Added new item in BottomCommandingContoller demo page that supports a Badge. To do so, CommandingItem was updated to have a new convenience init that takes in an optional badge. This badge is then provided to TableViewCell's customAccessoryView. Although BadgeView is a UIView, using badge directly with customAccessoryView did not work so the work around was to add it to a UIStackView first.

Verification

Before Light Dark
Simulator Screen Shot - iPhone 14 Pro - 2023-02-02 at 10 58 42 Simulator Screen Shot - iPhone 14 Pro - 2023-02-02 at 10 54 21 Simulator Screen Shot - iPhone 14 Pro - 2023-02-03 at 11 50 44

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@joannaquu joannaquu marked this pull request as ready for review February 7, 2023 18:47
@joannaquu joannaquu requested a review from a team as a code owner February 7, 2023 18:47
…oannaquu/fluentui-apple into joannaqu/add-to-bottom-commanding-demo
@joannaquu joannaquu merged commit 96a49ee into microsoft:main Feb 8, 2023
@joannaquu joannaquu deleted the joannaqu/add-to-bottom-commanding-demo branch February 8, 2023 16:53
@harrieshin harrieshin mentioned this pull request Feb 14, 2023
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants