Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename icon size tokens #1545

Merged

Conversation

laminesm
Copy link
Contributor

@laminesm laminesm commented Feb 6, 2023

Platforms Impacted

  • iOS
  • macOS

Description of changes

This PR updates icon size tokens to align their names with other sizing tokens.

Binary change:

File Before After Delta
libFluentUI.a 29,107,752 bytes 29,107,408 bytes -344 bytes

Verification

Before After
before_tvc after_tvc
before_card_nudge after_card_nudge
before_avatar_group after_avatar_group

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@laminesm laminesm requested a review from a team as a code owner February 6, 2023 20:06
@harrieshin harrieshin added the API break This PR introduces a breaking API change label Feb 6, 2023
Saadnajmi
Saadnajmi previously approved these changes Feb 6, 2023
@laminesm laminesm merged commit fd27c51 into microsoft:main Feb 6, 2023
@laminesm laminesm deleted the laminemale/update-icon-sizes-names branch February 6, 2023 20:47
@harrieshin harrieshin mentioned this pull request Feb 14, 2023
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API break This PR introduces a breaking API change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants