Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XCUITests] Test cleanup #1546

Merged
merged 7 commits into from
Feb 6, 2023
Merged

Conversation

joannaquu
Copy link
Contributor

@joannaquu joannaquu commented Feb 6, 2023

Platforms Impacted

  • iOS
  • macOS

Description of changes

Binary change:

File Before After Delta
libFluentUI.a 28,828,696 bytes 28,828,696 bytes 0 bytes

This PR does some final cleanup for XCUITests. It updates BaseTest to remain on the control page if it starts on the correct page and fixes all the small whitespace mistakes/syntax differences (use of both XCTAssertTrue and XCTAssert) that I've noticed. It also renames the test for AvatarView to AvatarViewTest.

Verification

No visual changes, pr checks all pass.
image

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)

@joannaquu joannaquu requested a review from a team as a code owner February 6, 2023 21:16
@joannaquu joannaquu merged commit fb339a0 into microsoft:main Feb 6, 2023
@joannaquu joannaquu deleted the joannaqu/test-cleanup branch February 6, 2023 23:23
@harrieshin harrieshin mentioned this pull request Feb 14, 2023
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants