Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring BottomSheet from fluent2-tokens into main #1553

Merged
merged 5 commits into from
Feb 9, 2023
Merged

Bring BottomSheet from fluent2-tokens into main #1553

merged 5 commits into from
Feb 9, 2023

Conversation

jeaniehuynh
Copy link
Contributor

@jeaniehuynh jeaniehuynh commented Feb 7, 2023 •
edited
Loading

Platforms Impacted

  • iOS
  • macOS

Description of changes

Bringing BottomSheet changes from fluent2-tokens into main

Binary change:
See #1490

Before After
IMG_0083 IMG_0082
IMG_0087 IMG_0086

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@jeaniehuynh jeaniehuynh requested a review from a team as a code owner February 7, 2023 01:27
@sophialee0416
Copy link
Contributor

Could we also maybe get dark theme + landscape confirmation as well? 😃

laminesm
laminesm reviewed Feb 7, 2023
View reviewed changes
Copy link
Contributor

@laminesm laminesm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind adding a readme string on the bottom sheet demo page? Maybe you could grab something from the repo documentation for now?

@harrieshin
Copy link
Contributor

please make sure all the fixes you made in this pr is reflected on the token branch as well to make the merge easier

@jeaniehuynh jeaniehuynh merged commit 4c81ac0 into microsoft:main Feb 9, 2023
@jeaniehuynh jeaniehuynh deleted the BottomSheetToMain branch February 9, 2023 00:48
@harrieshin harrieshin mentioned this pull request Feb 14, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huwilkes huwilkes huwilkes left review comments

@harrieshin harrieshin harrieshin left review comments

@mischreiber mischreiber mischreiber left review comments

@laminesm laminesm laminesm approved these changes

@edjamesmsft edjamesmsft edjamesmsft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jeaniehuynh @sophialee0416 @harrieshin @mischreiber @edjamesmsft @huwilkes @laminesm