Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avatar accessory image changed to accommodate multiple rendering modes #1554

Merged
merged 3 commits into from
Feb 7, 2023

Conversation

sophialee0416
Copy link
Contributor

@sophialee0416 sophialee0416 commented Feb 7, 2023

Platforms Impacted

  • iOS
  • macOS

Description of changes

In some scenarios, the activity image will not show even if the cutout is made within the Avatar if the image file is an SVG and the asset image is rendered as a Template Image. Added an SVG example in the demo controller and included hard-coded foreground color that will later be exposed as a token in a follow-up PR to unblock downstream dependencies.

Verification

Before After
image image
image image

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@sophialee0416 sophialee0416 requested a review from a team as a code owner February 7, 2023 03:13
@harrieshin
Copy link
Contributor

"Note: The images are showing but are currently not the correct color. This will come in a later PR." even if we aren't introducing the public token right away for .12 patch, we can still define the static constant value?

Copy link
Contributor

@harrieshin harrieshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 comments

@sophialee0416
Copy link
Contributor Author

sophialee0416 commented Feb 7, 2023

"Note: The images are showing but are currently not the correct color. This will come in a later PR." even if we aren't introducing the public token right away for .12 patch, we can still define the static constant value?

Seems like SwiftUI won't allow images to take on custom foreground colors, which I can't include in this change because that would mean exposing a new API (mentioned in thread above)

ETA: No new API should be needed after an offline conversation

@harrieshin
Copy link
Contributor

please update PR description screenshots? i think darkmode bug should be fixed

@sophialee0416 sophialee0416 enabled auto-merge (squash) February 7, 2023 04:49
@sophialee0416 sophialee0416 changed the title Avatar accessory image changed to be original rendering mode Avatar accessory image changed to accommodate multiple rendering modes Feb 7, 2023
@sophialee0416 sophialee0416 merged commit 1d1aacf into microsoft:main Feb 7, 2023
sophialee0416 added a commit to sophialee0416/fluentui-apple that referenced this pull request Feb 7, 2023
@sophialee0416 sophialee0416 deleted the avatarActivityRendering branch February 7, 2023 05:09
sophialee0416 added a commit that referenced this pull request Feb 7, 2023
[main_0.12] Cherry-picking: Avatar accessory image changed to be original rendering mode (#1554)
@harrieshin harrieshin mentioned this pull request Feb 14, 2023
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants