-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avatar accessory image changed to accommodate multiple rendering modes #1554
Avatar accessory image changed to accommodate multiple rendering modes #1554
Conversation
"Note: The images are showing but are currently not the correct color. This will come in a later PR." even if we aren't introducing the public token right away for .12 patch, we can still define the static constant value? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 comments
Seems like SwiftUI won't allow images to take on custom foreground colors, which I can't include in this change because that would mean exposing a new API (mentioned in thread above) ETA: No new API should be needed after an offline conversation |
…r, and adding foreground color
please update PR description screenshots? i think darkmode bug should be fixed |
[main_0.12] Cherry-picking: Avatar accessory image changed to be original rendering mode (#1554)
Platforms Impacted
Description of changes
In some scenarios, the activity image will not show even if the cutout is made within the Avatar if the image file is an SVG and the asset image is rendered as a Template Image. Added an SVG example in the demo controller and included hard-coded foreground color that will later be exposed as a token in a follow-up PR to unblock downstream dependencies.
Verification
Pull request checklist
This PR has considered:
Microsoft Reviewers: Open in CodeFlow