Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main_0.13] [cherry-pick] PillButton text should not scale with DynamicType. (#1601) #1605

Merged

Conversation

mischreiber
Copy link
Contributor

@mischreiber mischreiber commented Feb 24, 2023

Set the shouldScale parameter to false.

Platforms Impacted

  • iOS
  • macOS

Description of changes

Cherry pick:

Verification

(how the change was tested, including both manual and automated tests)

Visual Verification
Before After
Screenshot or description before this change Screenshot or description with this change

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@mischreiber mischreiber requested a review from a team as a code owner February 24, 2023 23:24
@mischreiber mischreiber enabled auto-merge (squash) February 24, 2023 23:25
@mischreiber mischreiber merged commit 6ef687b into microsoft:main_0.13 Feb 24, 2023
@mischreiber mischreiber mentioned this pull request Feb 25, 2023
11 tasks
@mischreiber mischreiber deleted the mischreiber/pillbutton-cherrypick branch March 16, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants