Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dynamicColor from remaining demo controllers #1832

Merged
merged 5 commits into from
Jul 19, 2023

Conversation

joannaquu
Copy link
Contributor

@joannaquu joannaquu commented Jul 18, 2023

Platforms Impacted

  • iOS
  • macOS

Description of changes

Cleaning up some remaining instances of dynamicColor in our demo controllers. Followup to #1655.

Binary change

Total increase: 0 bytes
Total decrease: 0 bytes

File Before After Delta
Total 46,418,544 bytes 46,418,544 bytes 🎉 0 bytes
Full breakdown
File Before After Delta

Verification

Visual Verification
Before After
navigation before navigation after
theme before theme after
per before per after
readme before readme after

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: codeflow:open?pullrequest=#1832

@joannaquu joannaquu requested a review from a team as a code owner July 18, 2023 22:43
@joannaquu joannaquu merged commit 01aacfc into microsoft:main Jul 19, 2023
@joannaquu joannaquu deleted the joannaqu/dynamic-color branch July 20, 2023 21:33
@nodes11 nodes11 mentioned this pull request Aug 21, 2023
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants