Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CardNudge to allow multi-line title and message action #1851

Merged
merged 5 commits into from
Jul 28, 2023

Conversation

huwilkes
Copy link
Collaborator

@huwilkes huwilkes commented Jul 27, 2023

Platforms Impacted

  • iOS
  • macOS

Description of changes

Updates the CardNudge to allow the title to have multiple lines, and an option action for when the text/leading icon are tapped on. Also fixes an extra padding issue with the dismiss button. And adds hover effects on all the buttons.

Binary change

Total increase: 165,632 bytes
Total decrease: 0 bytes

File Before After Delta
Total 30,256,120 bytes 30,421,752 bytes 🛑 165,632 bytes
Full breakdown
File Before After Delta
CardNudge.o 386,376 bytes 448,392 bytes 🛑 62,016 bytes
SwiftUI+ViewModifiers.o 161,800 bytes 211,432 bytes ⚠️ 49,632 bytes
__.SYMDEF 4,637,272 bytes 4,685,568 bytes ⚠️ 48,296 bytes
CardNudgeModifiers.o 39,592 bytes 44,856 bytes ⚠️ 5,264 bytes
FocusRingView.o 799,864 bytes 800,248 bytes ⚠️ 384 bytes
MSFCardNudge.o 36,440 bytes 36,480 bytes ⚠️ 40 bytes

Verification

Visual Verification
Before After
CardNudge_Before CardNudge_After
n/a CardNudge_MultiHover_After

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: codeflow:open?pullrequest=#1851

@huwilkes huwilkes requested a review from a team as a code owner July 27, 2023 21:14
@huwilkes huwilkes merged commit 5a04fc6 into main Jul 28, 2023
@nodes11 nodes11 mentioned this pull request Aug 21, 2023
11 tasks
@huwilkes huwilkes deleted the huwilkes/cardNudge branch August 24, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants