Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call updateAppearance in BadgeField #1852

Merged
merged 2 commits into from
Jul 31, 2023

Conversation

joannaquu
Copy link
Contributor

@joannaquu joannaquu commented Jul 28, 2023

Platforms Impacted

  • iOS
  • macOS

Description of changes

When #1843 was checked in, it removed calls to set the BadgeField's colors and fonts. This PR adds a call to updateAppearance so that tokens can be set on init.

Binary change

Total increase: 64 bytes
Total decrease: 0 bytes

File Before After Delta
Total 46,915,960 bytes 46,916,024 bytes ⚠️ 64 bytes
Full breakdown
File Before After Delta
BadgeField.o 961,144 bytes 961,208 bytes ⚠️ 64 bytes

Verification

Visual Verification

No visual changes

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: codeflow:open?pullrequest=#1852

@joannaquu joannaquu requested a review from a team as a code owner July 28, 2023 21:24
@joannaquu joannaquu merged commit 8049862 into microsoft:main Jul 31, 2023
@joannaquu joannaquu deleted the joannaqu/fix-badge-field branch July 31, 2023 15:58
@nodes11 nodes11 mentioned this pull request Aug 21, 2023
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants