Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add xcbeautify for our ci results #1882

Merged
merged 4 commits into from
Sep 1, 2023

Conversation

harrieshin
Copy link
Contributor

@harrieshin harrieshin commented Sep 1, 2023

Platforms Impacted

  • iOS
  • macOS

Description of changes

  • To make the build errors and test results little bit more human readable lets start using xcbeautfiy in our ci.
  • lets remove CI checks for couple of branches we don't have any more like fluent-token.
  • Our CI runs lot of different flavors but i don't think it is all necessary. We can't build and test the demo app without the fluent library builds. Most of the time we just need to ensure our release iOS device builds correctly which isn't as common for normal development cycle.

Binary change

n/a

Verification

run ci

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@harrieshin harrieshin requested a review from a team as a code owner September 1, 2023 21:08
@harrieshin harrieshin merged commit b960cdd into microsoft:main Sep 1, 2023
@huwilkes huwilkes mentioned this pull request Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants