Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deprecated Label inits in demo app #1917

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

huwilkes
Copy link
Collaborator

@huwilkes huwilkes commented Oct 18, 2023

Platforms Impacted

  • iOS
  • macOS

Description of changes

#1914 deprecated the init of Label that used the typography alias tokens, but the demo didn't complain loudly enough that it was still using the deprecated init for these to get removed in that PR.

Verification

No deprecation warnings while building

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@huwilkes huwilkes requested a review from a team as a code owner October 18, 2023 01:25
@huwilkes huwilkes enabled auto-merge (squash) October 18, 2023 17:26
@huwilkes huwilkes merged commit 056ecab into microsoft:main Oct 18, 2023
6 checks passed
@mischreiber
Copy link
Contributor

Are we missing some build flags to catch this in the future, I wonder?

@huwilkes huwilkes mentioned this pull request Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants