-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cbowdoin/bottom sheet supports x axis constraints #1951
Merged
cbowdoin
merged 14 commits into
microsoft:main
from
cbowdoin:cbowdoin/BottomSheetSupportsXAxisConstraints
Feb 20, 2024
Merged
Cbowdoin/bottom sheet supports x axis constraints #1951
cbowdoin
merged 14 commits into
microsoft:main
from
cbowdoin:cbowdoin/BottomSheetSupportsXAxisConstraints
Feb 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodes11
reviewed
Jan 25, 2024
laminesm
reviewed
Jan 25, 2024
laminesm
reviewed
Jan 25, 2024
laminesm
reviewed
Jan 25, 2024
laminesm
reviewed
Jan 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this change meant to be iPad only?
…lso fixed minor formatting issuees
cbowdoin
force-pushed
the
cbowdoin/BottomSheetSupportsXAxisConstraints
branch
from
January 25, 2024 18:24
086b419
to
bf218a5
Compare
nodes11
approved these changes
Jan 30, 2024
anandrajeswaran
approved these changes
Feb 13, 2024
nodes11
approved these changes
Feb 16, 2024
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
BottomSheetController.swift
Adds 2 new properties to bottom sheets: preferredWidth and anchoredEdge.
PreferredWidth allows for custom width specification for bottom sheets. The sheet will attempt to set the width to the size specified as long as the value is between the minimum and maximum width of the sheet. If the value is not within that range, we will revert back to the original behavior of using the max width.
To avoid conflicts with should always fill width these properties unset each other when one is set.If should always fill width is set we will take this as the primary source of truth and defer behavior to this value being set.
AnchoredEdge allows the user to specify which edge we will constrain the sheet to. By default this remains keeping the sheet centered but when set users can move the sheet to be attached to the leading or trailing edge with a padding of 8.
BottomSheetDemoController.swift
recenter the sheet
Binary change
Total increase: 39,000 bytes
Total decrease: -3,816 bytes
Full breakdown
Verification
Tested using the bottom sheet demo. Initialized the sheet with properties for the various scenarios.
Preferred Width
AnchoredEdge
Visual Verification
Pull request checklist
This PR has considered:
Microsoft Reviewers: Open in CodeFlow