Update onChange to use onChange_iOS17

[joannaquu]

Platforms Impacted

• iOS
• macOS

Description of changes

#1957 added a new case of onChange(of:_:), which is deprecated in visionOS. Use onChange_iOS17(of:_:) instead.

Binary change

Total increase: 9,248 bytes
Total decrease: 0 bytes

File	Before	After	Delta
Total	30,918,264 bytes	30,927,512 bytes	⚠️ 9,248 bytes

Full breakdown

File	Before	After	Delta
ActivityIndicator.o	155,232 bytes	163,568 bytes	⚠️ 8,336 bytes
__.SYMDEF	4,770,720 bytes	4,771,632 bytes	⚠️ 912 bytes

Verification

visionOS builds again

Pull request checklist

This PR has considered:

• Light and Dark appearances
• iOS supported versions (all major versions greater than or equal current target deployment version)
• VoiceOver and Keyboard Accessibility
• Internationalization and Right to Left layouts
• Different resolutions (1x, 2x, 3x)
• Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
• iPad Pointer interaction
• SwiftUI consumption (validation or new demo scenarios needed)
• Objective-C exposure (provide it only if needed)

Microsoft Reviewers: Open in CodeFlow