Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add visionOS to pr template #1970

Merged
merged 2 commits into from
Feb 14, 2024
Merged

Add visionOS to pr template #1970

merged 2 commits into from
Feb 14, 2024

Conversation

joannaquu
Copy link
Contributor

@joannaquu joannaquu commented Feb 13, 2024 •
edited
Loading

Platforms Impacted

  • iOS
  • visionOS
  • macOS

Description of changes

Add visionOS to pr template

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@joannaquu joannaquu requested a review from a team as a code owner February 13, 2024 21:24
@joannaquu joannaquu enabled auto-merge (squash) February 14, 2024 18:35
@joannaquu joannaquu merged commit 744b550 into microsoft:main Feb 14, 2024
7 checks passed
@joannaquu joannaquu deleted the joannaqu/pr-template branch March 1, 2024 19:11
@mischreiber mischreiber mentioned this pull request Mar 6, 2024
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mischreiber mischreiber mischreiber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joannaquu @mischreiber