Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update accessoryCheckmarkColor on visionOS to be white #1999

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

joannaquu
Copy link
Contributor

@joannaquu joannaquu commented Apr 22, 2024

Platforms Impacted

  • iOS
  • visionOS
  • macOS

Description of changes

On visionOS, accessoryCheckmarkColor is currently brandForeground1. It should be white.

Binary change

Total increase: 1,144 bytes
Total decrease: 0 bytes

File Before After Delta
Total 31,358,040 bytes 31,359,184 bytes ⚠️ 1,144 bytes
Full breakdown
File Before After Delta
TableViewCellTokenSet.o 125,040 bytes 126,032 bytes ⚠️ 992 bytes
__.SYMDEF 4,830,360 bytes 4,830,512 bytes ⚠️ 152 bytes

Verification

Visual Verification
Before After
before after

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@joannaquu joannaquu requested a review from a team as a code owner April 22, 2024 19:26
@joannaquu joannaquu merged commit a9ac8e4 into microsoft:main Apr 22, 2024
7 checks passed
@joannaquu joannaquu deleted the joannaqu/tvc-check-color branch April 22, 2024 20:41
@joannaquu joannaquu mentioned this pull request May 23, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants