Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not show Profile button when avatarOverrideStyle is set #2027

Merged

Conversation

DanielMorM
Copy link
Contributor

@DanielMorM DanielMorM commented May 21, 2024

Platforms Impacted

  • iOS
  • visionOS
  • macOS

Description of changes

If we have set avatarOverrideStyle + using iPad size class, we end up having two avatars, one in the side bar and another in the navigation bar. The avatarOverrideStyle is used to override the style, it should not dictate if we show/hide the Profile button.

Verification

Locally tested:

  • No duplicate avatar showing up if we have a side bar + avatarOverrideStyle
  • The empty avatar and profile avatar are displayed correctly (with and without side bar)

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@DanielMorM DanielMorM requested a review from a team as a code owner May 21, 2024 01:35
@DanielMorM DanielMorM enabled auto-merge (squash) May 22, 2024 18:15
@DanielMorM DanielMorM merged commit db897b8 into main May 22, 2024
7 checks passed
@DanielMorM DanielMorM deleted the user/damoral/avoid-showing-avatar-whe-overriden-style branch May 22, 2024 19:20
@joannaquu joannaquu mentioned this pull request May 23, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants