Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding verticalOffset property to FluentNotification #2045

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

mischreiber
Copy link
Contributor

@mischreiber mischreiber commented Jun 13, 2024

Platforms Impacted

  • iOS
  • visionOS
  • macOS

Description of changes

Adding a new argument to FluentNotification that allows for custom vertical offset of the shown notification when presented from SwiftUI.

Binary change

Total increase: 8,504 bytes
Total decrease: 0 bytes

File Before After Delta
Total 31,174,120 bytes 31,182,624 bytes ⚠️ 8,504 bytes
Full breakdown
File Before After Delta
FluentNotification.o 644,768 bytes 651,368 bytes ⚠️ 6,600 bytes
__.SYMDEF 4,848,192 bytes 4,850,056 bytes ⚠️ 1,864 bytes
MSFNotification.o 138,632 bytes 138,672 bytes ⚠️ 40 bytes

Verification

New API works! And defaults to original behavior when unmodified.

Visual Verification
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-06-12.at.18.21.36.mp4

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@mischreiber mischreiber requested a review from a team as a code owner June 13, 2024 01:25
@mischreiber mischreiber enabled auto-merge (squash) June 19, 2024 04:15
@mischreiber mischreiber merged commit a7c83b5 into microsoft:main Jun 19, 2024
7 checks passed
@mischreiber mischreiber deleted the notificationVerticalOffset branch June 20, 2024 20:34
@mischreiber mischreiber mentioned this pull request Jun 24, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants