Various a11y fixes for SearchBar and BadgeView #2054
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
Problems
Our SearchBar and BadgeView have a few a11y and layout issues.
leadingView
is only calculated once, and doesn't react to parent view size changes or content size category updates (where the leading view may need more space).largeContentTitle
prop, so when largeContentViewer is enabled it shows a blank view.For this PR, I'm assuming our SearchBar fixed height is a hard limit - changing this could have major fallout for clients. Instead let's make this view as accessible as we can within the limits.
leadingView
- this now uses pure Auto Layout to enforce min width for the input field, but also good amount of space forleadingView
Binary change
Total increase: 6,464 bytes
Total decrease: -1,776 bytes
Full breakdown
Verification
Local testing in sim, various dynamic type size, restricted width scenarios, screen rotation, usage inside Fluent NavigationController.
Visual Verification
Pull request checklist
This PR has considered:
Microsoft Reviewers: Open in CodeFlow