Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing swiftlint for new folder config #2093

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

mischreiber
Copy link
Contributor

@mischreiber mischreiber commented Sep 30, 2024

Platforms Impacted

  • iOS
  • visionOS
  • macOS

Description of changes

Updating .swiftlint.yml to reference new directory paths, and suppressing one warning that was added while it was broken.

Binary change

n/a -- only changing how the linter is run, no code changes.

Verification

Ran the linter locally:

Done linting! Found 0 violations, 0 serious in 402 files.

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@mischreiber mischreiber requested review from a team as code owners September 30, 2024 21:20
@mischreiber mischreiber merged commit 308f8b7 into microsoft:main Oct 2, 2024
7 checks passed
@mischreiber mischreiber deleted the fix_swiftlint branch October 2, 2024 19:33
@mischreiber mischreiber mentioned this pull request Oct 17, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants